Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Publish Scala 3 alongside Scala CLI as the scala runner on winget #20381

Closed
Gedochao opened this issue May 10, 2024 · 6 comments · Fixed by #21009
Closed

Publish Scala 3 alongside Scala CLI as the scala runner on winget #20381

Gedochao opened this issue May 10, 2024 · 6 comments · Fixed by #21009
Assignees
@hamzaremmal
Labels
area:ci Issues tied with CI/CD workflows area:package-manager area:runner Issues tied to the scala runner command. itype:enhancement

Comments

@Gedochao
Copy link
Contributor

https://learn.microsoft.com/en-us/windows/package-manager/winget/

Example from Scala CLI repo:
https://github.com/VirtusLab/scala-cli/blob/main/.github/workflows/ci.yml#L1679-L1684
@Gedochao Gedochao added itype:enhancement area:ci Issues tied with CI/CD workflows area:runner Issues tied to the scala runner command. labels May 10, 2024
@Gedochao
Copy link
Contributor Author

Gedochao commented Jul 3, 2024

Note: if we end up using the winget-releaser GitHub action, make sure to use it on @main rather than v2.
Context:

@hamzaremmal
Copy link
Member

I'm not a big fan of using @main tbh

@Gedochao
Copy link
Contributor Author

Gedochao commented Jul 3, 2024

I'm not a big fan of using @main tbh

I bet, but it seems the recent fixes aren't on v2...

@hamzaremmal
Copy link
Member

Yea, since that PR is opened by the owner of the repository, I asked in VirtusLab/scala-cli#2991 (comment)

@bishabosha
Copy link
Member

bishabosha commented Jul 3, 2024 •
edited
Loading

you can also do @<commit-hash>?

@hamzaremmal
Copy link
Member

Yes we can always do that (which is my backup plan if no release with this changes is done)
I'd rather have a release since @dependabot can suggest to update the dependency.

@hamzaremmal hamzaremmal mentioned this issue Jul 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hamzaremmal hamzaremmal

Labels
area:ci Issues tied with CI/CD workflows area:package-manager area:runner Issues tied to the scala runner command. itype:enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add workflow to release to winget hamzaremmal/scala3
3 participants
@bishabosha @Gedochao @hamzaremmal