Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge cc-experiment into main? #15756

Closed
odersky opened this issue Jul 26, 2022 · 0 comments · Fixed by #15877
Closed

Merge cc-experiment into main? #15756

odersky opened this issue Jul 26, 2022 · 0 comments · Fixed by #15877

Comments

@odersky
Copy link
Contributor

odersky commented Jul 26, 2022

I wanted to get some discussion going when we should merge cc-experiment into main. All user-visible changes of cc-experiment should be controlled by flag -Ycc, and all library additions should be @experimental.

Once that's the case, I believe it's time to merge cc-experiment.

The upsides of doing this include:

  • No more large scale risky rebases (it's been very hard at times to rebase such a large change set)
  • Better visibility when changes to main break some aspect of cc-experiment
  • Easier context switches
  • I am the main contributor on both branches and this will save me a lot of time.
  • It's a necessary step to allow experimental extensions such as safe exceptions
  • It's a necessary step to use capture checking in the compiler itself.

The downsides include:

  • Code in cc-experiment might be less stable than main
  • Code in cc-experiment might make it harder to understand the compiler codebase (although it is fairly well factored out).
@odersky odersky added stat:needs triage Every issue needs to have an "area" and "itype" label itype:question and removed stat:needs triage Every issue needs to have an "area" and "itype" label labels Jul 26, 2022
@odersky odersky linked a pull request Aug 20, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant