Nightly Dotty workflow of 2021-12-17 failed

[github-actions]

See https://github.com/lampepfl/dotty/actions/runs/1590471888

[smarter]

test_java8 is failing with:

Error: Test dotty.tools.scripting.BashScriptsTests.verifyScriptPathProperty failed: java.lang.AssertionError: assertion failed: script /__w/dotty/dotty/out/bootstrap/scala3-compiler-bootstrapped/scala-3.1.2-RC1-bin-SNAPSHOT-nonbootstrapped/test-classes/scripting/scriptPath.sc did not report valid script.path value, took 0.024 sec

/cc @philwalk @BarkingBad

[odersky]

Is there a way to test nightlies before they happen? We had far too many failing tests recently. So if there is an infrastructure change, it would be good to make sure beforehand that the nightlies continue to work.

[dwijnand]

I think #14109 was closed because of #14113, but maybe there was just a misunderstanding.

[smarter]

You can run extra nightly-only tests by adding them to the PR description, #14113 in particular tested that [test_windows_full] and [test_non_bootstrapped] worked, but it didn't add [test_java8] which is the one which is now broken.

[philwalk]

WRT to wny java8 test is failing, the following testlog output is relevant:

2021-12-17T03:15:25.5437141Z JAVA_HOME : /usr/lib/jvm/java-8-openjdk-amd64
2021-12-17T03:15:25.5438737Z SCALA_HOME : not-found
2021-12-17T03:15:25.5441164Z PATH : dist/target/pack/bin:/usr/lib/jvm/java-8-openjdk-amd64/bin:not-found/bin:/usr/local/sbt/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
2021-12-17T03:15:25.5443505Z SHELLOPTS : braceexpand:hashall:ignoreeof:monitor:vi
2021-12-17T03:15:25.5512694Z stderr: [/usr/bin/bash: /__w/dotty/dotty/out/bootstrap/scala3-compiler-bootstrapped/scala-3.1.2-RC1-bin-SNAPSHOT-nonbootstrapped/test-classes/scripting/scriptPath.sc: dist/target/pack/bin/scala: bad interpreter: No such file or directory]

Here's how scalaHome is configured in the test setup:

  // envScalaHome is:
  //    dist/target/pack, if present
  //    else, SCALA_HOME if defined
  //    else, not defined
  lazy val envScalaHome =
    printf("scalacPath: %s\n", scalacPath.norm)
    if scalacPath.isFile then scalacPath.replaceAll("/bin/scalac", "")
    else envOrElse("SCALA_HOME", "not-found").norm

The fix is probably to add dist/pack; to line 406 in ci.yaml:

          ./project/scripts/sbt ";dist/pack;scala3-bootstrapped/compile ;scala3-bootstrapped/test;sjsSandbox/run;sjsSandbox/test;sjsJUnitTests/test;sjsCompilerTests/test ;sbt-test/scripted scala2-compat/* ;configureIDE ;stdlib-bootstrapped/test:run ;stdlib-bootstrapped-tasty-tests/test"

For diagnosing test failures, it would be nice to be able run CI tests locally before pushing code changes. I don't currently know how to do that.

[BarkingBad]

I already added that, though @smarter made a good point in this thread