Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken test in specs2 #336

Closed
ashawley opened this issue Jul 10, 2019 · 2 comments
Closed

Broken test in specs2 #336

ashawley opened this issue Jul 10, 2019 · 2 comments

Comments

@ashawley
Copy link
Member

After applying the fix to #57, there's a strange test in specs2 that is checking the XML output with the result of scala.xml.Utility.escape:

https://github.com/etorreborre/specs2/blob/c7bc40bf6c/junit/jvm/src/test/scala/org/specs2/reporter/JUnitXmlPrinterSpec.scala#L94

I knew the XML output of quotation marks would change for users. I didn't expect tests that would be using Utility.escape to validate things. I'm not sure there is a workaround for this with libraries that need to cross-compile.

@SethTisue
Copy link
Member

SethTisue commented Jul 10, 2019

thanks for opening this, it was in my queue to open a ticket myself, since this turned up in the community build, but I hadn't gotten to it :-)

I think it would be reasonable to ask specs2 to find another way to write the test. or to allow either of the two different expected outputs as correct /cc @etorreborre

@ashawley
Copy link
Member Author

Thanks, Seth. Fixed in etorreborre/specs2#754.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants