Skip to content

Commit

Permalink
Merge pull request playframework#830 from mkurz/upgrade_workaround
Browse files Browse the repository at this point in the history
Small workaround that allows us to upgrade akka independent of Play
  • Loading branch information
mkurz authored Dec 7, 2023
2 parents cf367f8 + 6827062 commit e599101
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 4 deletions.
2 changes: 1 addition & 1 deletion build.sbt
Original file line number Diff line number Diff line change
Expand Up @@ -371,7 +371,7 @@ lazy val `integration-tests` = project
Test / fork := true,
concurrentRestrictions += Tags.limitAll(1), // only one integration test at a time
Test / testOptions := Seq(Tests.Argument(TestFrameworks.JUnit, "-a", "-v")),
libraryDependencies ++= playNettyServer.map(_ % Test) ++ testDependencies,
libraryDependencies ++= backendServerTestDependencies ++ testDependencies,
)
.settings(shadedAhcSettings)
.settings(shadedOAuthSettings)
Expand Down
18 changes: 15 additions & 3 deletions project/Dependencies.scala
Original file line number Diff line number Diff line change
Expand Up @@ -42,9 +42,21 @@ object Dependencies {

val asyncHttpClient = Seq("org.asynchttpclient" % "async-http-client" % "2.12.3")

val akkaStreams = Seq("com.typesafe.akka" %% "akka-stream" % "2.6.20")

val playNettyServer = Seq("com.typesafe.play" %% "play-netty-server" % "2.9.0")
val akkaVersion = "2.6.20"

val akkaStreams = Seq("com.typesafe.akka" %% "akka-stream" % akkaVersion)

val backendServerTestDependencies = Seq(
"com.typesafe.play" %% "play-netty-server" % "2.9.0",
// Following dependencies are pulled in by play-netty-server, we just make sure
// now that we use the same akka version here like akka-stream above.
// This is because when upgrading the akka version in Play and play-ws here we usually release
// a new Play version before we can bump it here, so the versions will always differ for a short time.
// Since these deps are only used in tests it does not matter anyway.
"com.typesafe.akka" %% "akka-actor-typed" % akkaVersion,
"com.typesafe.akka" %% "akka-serialization-jackson" % akkaVersion,
"com.typesafe.akka" %% "akka-slf4j" % akkaVersion
).map(_ % Test)

val reactiveStreams = Seq("org.reactivestreams" % "reactive-streams" % "1.0.4")

Expand Down

0 comments on commit e599101

Please sign in to comment.