Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable ExplicitResultTypes #549

Merged
merged 1 commit into from
Sep 4, 2021
Merged

Enable ExplicitResultTypes #549

merged 1 commit into from
Sep 4, 2021

Conversation

japgolly
Copy link
Contributor

@japgolly japgolly commented Sep 4, 2021

Closes #470

@japgolly japgolly requested a review from armanbilge September 4, 2021 04:32
japgolly
japgolly commented Sep 4, 2021
View reviewed changes
prePR.sbt Show resolved Hide resolved
japgolly
japgolly commented Sep 4, 2021
View reviewed changes
prePR.sbt Show resolved Hide resolved
armanbilge
armanbilge approved these changes Sep 4, 2021
View reviewed changes
Copy link
Member

@armanbilge armanbilge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really glad we're adding this. Scalafix is awesome!!

@armanbilge armanbilge merged commit 74a6528 into master Sep 4, 2021
@japgolly japgolly deleted the topic/reformat branch September 4, 2021 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@armanbilge armanbilge armanbilge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Scalafix ExplicitResultTypes rule
2 participants
@japgolly @armanbilge