Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make crypto.subtle.importKey return a js.Promise[CryptoKey] #431

Merged
merged 3 commits into from
Aug 20, 2021
Merged

Make crypto.subtle.importKey return a js.Promise[CryptoKey] #431

merged 3 commits into from
Aug 20, 2021

Conversation

japgolly
Copy link
Contributor

@armanbilge armanbilge changed the base branch from master to series/1.x August 10, 2021 02:02
@japgolly japgolly marked this pull request as draft August 12, 2021 23:54
@japgolly japgolly added this to the v1.2.0 milestone Aug 13, 2021
@japgolly japgolly marked this pull request as ready for review August 20, 2021 02:23
@japgolly
Copy link
Contributor Author

Merged as this is already approved, thanks @armanbilge

@japgolly japgolly merged commit 6d9ae70 into scala-js:series/1.x Aug 20, 2021
@japgolly japgolly deleted the importKey branch August 20, 2021 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@armanbilge armanbilge armanbilge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@japgolly @armanbilge