Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added FileReaderSync to dom.experimental #424

Merged
merged 4 commits into from
Aug 25, 2021
Merged

Added FileReaderSync to dom.experimental #424

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
23c4c43
Added FileReaderSync to dom.experimental
catap Sep 30, 2020
8ae664b
Merge branch 'series/1.x' into FileReaderSync
armanbilge Aug 23, 2021
e0a2c6a
Run `prePR`
armanbilge Aug 23, 2021
a1ced71
Fix default argument
armanbilge Aug 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion api-reports/2_12.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,7 +239,7 @@ experimental/Chunk[JT] def value: T
experimental/Fetch[JO] def fetch(info: RequestInfo, init: RequestInit = null): js.Promise[Response]
experimental/FileReaderSync[JC] def readAsArrayBuffer(blob: Blob): ArrayBuffer
experimental/FileReaderSync[JC] def readAsDataURL(blob: Blob): URL
experimental/FileReaderSync[JC] def readAsText(blob: Blob, encoding: String = "UTF-8"): String
experimental/FileReaderSync[JC] def readAsText(blob: Blob, encoding: String?): String
experimental/Fullscreen[SO] def exitFullscreen(): js.UndefOr[js.Promise[Unit]]
experimental/Fullscreen[SO] def fullscreenElement: Element
experimental/Fullscreen[SO] def fullscreenEnabled: Boolean
Expand Down
2 changes: 1 addition & 1 deletion api-reports/2_13.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,7 +239,7 @@ experimental/Chunk[JT] def value: T
experimental/Fetch[JO] def fetch(info: RequestInfo, init: RequestInit = null): js.Promise[Response]
experimental/FileReaderSync[JC] def readAsArrayBuffer(blob: Blob): ArrayBuffer
experimental/FileReaderSync[JC] def readAsDataURL(blob: Blob): URL
experimental/FileReaderSync[JC] def readAsText(blob: Blob, encoding: String = "UTF-8"): String
experimental/FileReaderSync[JC] def readAsText(blob: Blob, encoding: String?): String
experimental/Fullscreen[SO] def exitFullscreen(): js.UndefOr[js.Promise[Unit]]
experimental/Fullscreen[SO] def fullscreenElement: Element
experimental/Fullscreen[SO] def fullscreenEnabled: Boolean
Expand Down
2 changes: 1 addition & 1 deletion src/main/scala/org/scalajs/dom/experimental/FileReaderSync.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,5 +44,5 @@ class FileReaderSync() extends js.Object {
*
* MDN
*/
def readAsText(blob: Blob, encoding: String = "UTF-8"): String = js.native
def readAsText(blob: Blob, encoding: String = js.native): String = js.native
japgolly marked this conversation as resolved.
Show resolved Hide resolved
}