Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

return type of triangle Area should be Double #36

Merged
merged 1 commit into from
Feb 26, 2018

Conversation

arjun1438
Copy link
Contributor

The triangleArea returns values 6.0 not 6 for triangleArea(3, 4)

The triangleArea returns values 6.0 not 6 for triangleArea(3, 4)
@FRosner
Copy link
Member

FRosner commented Feb 25, 2018

Hi! Thanks for the PR. The return type is already Double:

def triangleArea(base: Double, height: Double): Double

6 is equal to 6.0 but I see why it might be confusing. Do you think we should change it to 6.0? What is the motivation for the change?

@arjun1438
Copy link
Contributor Author

arjun1438 commented Feb 26, 2018 via email

@FRosner
Copy link
Member

FRosner commented Feb 26, 2018 via email

@FRosner FRosner merged commit 5575a61 into scala-exercises:master Feb 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants