-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The graph #25
The graph #25
Conversation
...tes/extensions/the-graph/packages/nextjs/components/ScaffoldEthAppWithProviders.tsx.args.mjs
Outdated
Show resolved
Hide resolved
templates/extensions/the-graph/packages/subgraph/abis/localhost_YourContract.json
Outdated
Show resolved
Hide resolved
templates/extensions/the-graph/packages/subgraph/scripts/abi_copy.ts
Outdated
Show resolved
Hide resolved
Thank you Shiv! This is awesome! 🔥 Tested it and everything works great! (MacOS, m1) Hopefully will play with graph extension next week |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome job @technophile-04!!
All cli combinations installed OK on Windows 10 👌.
Testing the different outputs, so far Graph working fine with hardhat after first tests, will continue testing and report back when finish 🙌
This message on graph yarn local-ship
, is port 8020 from first message OK?
- Deploying to Graph node http://localhost:8020/
Deployed to http://localhost:8000/subgraphs/name/scaffold-eth/your-contract/graphql
Great stuff!! Thanks all. I'm gonna send this PR to the graph people so they can also test before merging. |
Not sure if it should go in this PR, but a one-liner for installing would be great: npx create-eth@latest --extension the-graph
// or
npx create-eth@latest --e the-graph
// or with the defaults an no questions asked
npx create-eth@latest --e the-graph -y What do you all think? Happy to move this to a different issue/PR |
I think it's better to create a separate issue for it, since it's not clear what should be under |
Great job @technophile-04 !!! Tested on Ubuntu 20.04 and everything worked great, except yarn subgraph:test (getting a 404 error when trying to download the package). Added a small comment to README for Linux users. Thanks!! |
@technophile-04 In the instructions, these steps work for me:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only added a few nitpick comments, it's looking good to me 🙌
GJ!!
Update README on shipping subgraph to the graph studio. For this PR we pushing people to use do it via Created #28 which will allow people to ship the existing subgraph to the graph studio, it needs a bit testing and review 🙌 |
Great work @technophile-04 I'm excited to see this merged, as I already started on these changes myself. 🙌 I've tried to message @rin-st to resolve the open comments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some small stylistic inputs. Otherwise, this is amazing!
Thanks all! We moved this to https://github.com/scaffold-eth/create-eth-extensions repo (which holds the [curated extensions]( Line 15 in 99f6005
To try out you could do :
we are also still figuring / smoothing the rough edges on how to integrate extensions (curated vs external) More info in #32 (comment) for more details |
Description :
To test
the-graph
branchThen run:
In first terminal :
yarn install && yarn dev
In Second terminal :
You could choose solidity framework of your choice :), tweaked it a bit to work with both hardhat and foundry
The third question will prompt for whether to select
the-graph
extension or not. Use space to select / unselect and hit enter.You could check out generated README.md for instruction's to deploy subgraph locally
^ You will be needing Docker
I think we could maybe do better on generated README.md's but didn't go too crazy and we can iterate later. (Like accepting requirements, readme heading (eg. SE-2 with Subgraph) etc as args)