Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance Validation of the vacuums service calls #291

Open
2 tasks done
sca075 opened this issue Dec 1, 2024 · 0 comments
Open
2 tasks done

Enhance Validation of the vacuums service calls #291

sca075 opened this issue Dec 1, 2024 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@sca075
Copy link
Owner

sca075 commented Dec 1, 2024

Checklist

  • I have updated the integration to the latest version available
  • I have checked if the problem is already reported

The problem

Testing the integration, some of the services will need to be revised as per validation of the data didn't detect the object correctly. This cause that there is no error when the data are send to the vacuums with improper format. Will need to implement some validations routines so that for instance (error wise) there is a kind of user feed back.

What version of an integration has described problem?

2024.12.0b0

What was the last working version of an integration?

not specified

What vacuum model do you have problems with?

Roborock.S5

Please firmware installed on your Vacuum.

all

What type of platform you use?

ARM (Raspberry Pi, Odroid, etc.) > 4GB

What version of Home Assistant do you use?

2024.12.0b3

What type of installation are you running?

Home Assistant OS

Logs or Errors shown in the HA snapshots (please enable the Debug Mode) text will be auto formatted to code.

{
  "command": "zoned_cleanup",
 "id": "test_zone", ## correct   
"zone_ids": [
    {
      "id": "t",
      "repeats": 1
    },
    {
      "id": "e",
      "repeats": 1
    },
    {
      "id": "s",
      "repeats": 1
    },
    {
      "id": "t",
      "repeats": 1
    },
    {
      "id": "_",
      "repeats": 1
    },
    {
      "id": "z",
      "repeats": 1
    },
    {
      "id": "o",
      "repeats": 1
    },
    {
      "id": "n",
      "repeats": 1
    },
    {
      "id": "e",
      "repeats": 1
    }
  ],
  "afterCleaning": "Base"
}

Function, that in your opinion is creating the issue.

None

Additional information

Will be working on this as per a matter of fact as soon will be possible a target for the fix will be soon announced.

@sca075 sca075 added the bug Something isn't working label Dec 1, 2024
@sca075 sca075 self-assigned this Dec 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant