Issue with _handle_coordinator_update on 2024.10.0 #263
Comments
|
@Minims thanks for the report I will check it out and in the next version that I will release should be fixed. |
|
@Minims I think the issue you reported should be already fix on the beta 0 2024.11.0b0 pre release. Would you be so kind to confirm? |
|
@sca075 I have the exact same error with 2024.11.0b0 |
@Minims |
|
Does the Lovelace card make this call ? |
|
@Minims |
|
version 2024.11.0b0 Here is sensors i have :
and debug logs |
|
@Minims thanks a lot I appreciate your support and hopefully I can solve this issue soon 😉 |
|
@Minims |
|
@sca075 it change nothing, i have comment line 197 without success. also tried to comment all block 197-201 and the error still exists. |
|
Okay strange.. mmmmm I will try to find a solution to this in the next days.. thanks for your help |
|
@Minims I did try also on Proxmox updating the OS and HA to the later 2024.10.4 and I couldn't reproduce the issue with the last beta of the integration (no modified code). Although I'm aware that the coordinator will need to be refactored. The warning you are facing is probably due to the callback's that I will remove (as I tested this) in the next beta. I'm also studding the homeassistant/helpers/update_coordinator.py and I hope to conclude the troubleshooting within tomorrow. Will keep you posted ;) |
|
@Minims I think I found a workaround by renaming the _handle_coordinator_update to async_handle_coordinator_update. This avoid to call the helper.. I will work on this issue later on as per I would like to comply to the standards of Home Assistant. I got were is the problem in the implementation will release a new beta later on for you. |
|
@Minims would you be so kind to test Releases 2024.11.0b1 this should avoid the warning you reported keeping the sensors working. Would be nice when you can give me feedback as soon you have time to test it and also your kind feedback on the added sensors would be really appreciated. |
|
@sca075 I have just installed the beta this morning. All sensors are OK and up to date 
For now i don't see the usage of the additional sensors as i think i already have them in the vacuum attributes and all i need is already displayed in the Maybe it can avoid creating template sensors in some case or help with automation. 
About map change i need to have a look, for now i'm still using this : Thanks for your job ! |
|
Well I'm really glad, thanks for your inputs. The idea I had when I decided to implement the sensors for Rand256 was exactly what you mentioned. You see.. the official branch of Valetudo provides sensors via MQTT and this is helpful because we do not need to create templates sensors in Home Assistant as Rand256 provides just the attributes of vacuum. Also as the card already provides the go_to, clean_zone and clean_segment action but those are not registered as actions in Home Assistant.. I would create those vacuum actions from the integration and this should make things a little more easier for you guys setting up the automations and scripts. The integration is now supporting also the maploader add-on (official Valetudo) and the map_load of Rand256 capabilities in order to reset_trims automatically when the maps change. It is possible that after all and probably that I'm overthinking this but the aim is to get all in a box and just setup the vacuum to use it in Home Assistant as easy it can be. Thanks once again for your cooperation @Minims. |
|
@Minims released 2024.11.0 with the temp fix hopefully I can close this as soon the Coordinator will be fully integrated. Thanks once again. |
|
Thanks, installed, everything seems ok. |
Checklist
The problem
Since 2024.10.0 i have this error in HA logs.
I have reinstalled 2024.9.0, all is OK.
What version of an integration has described problem?
2024.10.0
What was the last working version of an integration?
2024.9.0
What vacuum model do you have problems with?
Roborock S5
Please firmware installed on your Vacuum.
No response
What type of platform you use?
ARM (Raspberry Pi, Odroid, etc.) > 4GB
What version of Home Assistant do you use?
2024.10.4
What type of installation are you running?
Home Assistant Supervised
Logs or Errors shown in the HA snapshots (please enable the Debug Mode) text will be auto formatted to code.
The text was updated successfully, but these errors were encountered: