Current room detection doesn't work well with non-rectangular rooms

[andrey-yantsen]

Checklist

• I have updated the integration to the latest version available
• I have checked if the problem is already reported

The problem

Firstly, thank you for the integration! It saved me a lot of time after I started using Valetudo.

I'm not sure if it's really a bug-report, or more of a feature request, but anyway. I have seven rooms on the map, defined as per screenshot below. When the robot is in the room 2, the integration reports it as being in the room 1. And room 4 is often being reported as room 3 (and sometimes 6).

Would it be possible to improve room detection for such cases?

What version of an integration has described problem?

v2024.10.0

What was the last working version of an integration?

No response

What vacuum model do you have problems with?

Roborock S7

Please firmware installed on your Vacuum.

No response

What type of platform you use?

VEMLinux (Virtual Machine) such as Proxmox, VMWare, etc.

What version of Home Assistant do you use?

2024.10.3

What type of installation are you running?

Home Assistant OS

Logs or Errors shown in the HA snapshots (please enable the Debug Mode) text will be auto formatted to code.

No response

Function, that in your opinion is creating the issue.

Not sure / none of the above.

Additional information

No response

[sca075]

@andrey-yantsen thanks for your report, I will check it soon, at the moment I'm working on other items for the next release but surely will do my best to fix this.
I understand that the in_room variable is not updated correctly from your report.
Probably within the next beta or the final release of 2024.11.0 this will work again correctly 😉

Sorry for the inconvenience anyway. Thanks for your feedback.

[sca075]

@andrey-yantsen I did some investigation and you are correct the update of the robot in_room of course depends from the room proprieties. It's a little complicated and I did try already in the past, but I think that the rooms coordinates, instead of a box could be more.. detailed. Unfortunately although I can't work on it in the immediate. but will do my best to fix it, as this is a valuable input.

[andrey-yantsen]

Yeah, I expected it might not be that straightforward. Thanks for looking into this, anyway!

[sca075]

@andrey-yantsen I had an idea and I will test it soon.
The robot moves in the room and each room has a color.. so I think I can get it easily done with the correlation robot position and color at that position. If it works will add it in the 2024.11.0

[andrey-yantsen]

Haha, that's bold! :D Great idea, I love it. Thank you for still thinking about it!

I'm guessing Valetudo does not report the room borders in an easily digestible way?

[sca075]

I'm guessing Valetudo does not report the room borders in an easily digestible way?

We get front the vacuum a json with "compressed" coordinates and nope no in_room payload... there could be a method to use the walls to calculate the boundaries.. also processing wise this kind of operations are quite heavy to do in python and Numpy. And to be honest selection of the room do not use a box segment requires only the segment ID and when the segment is selected for cleaning it fades as color.