-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows generated script gives error #37
Comments
@jchab - thoughts on the right fix? |
I did some quick testing and it does look like switching the single quotes to double should fix the problem. |
Thanks! @Chemmo do you want to make a pull request? I can do it "blind" (no Windows) but it might be nicer for someone with Windows to give it a shot and test it. |
@havocp Can you please merge the pull request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I think the quoting is invalid in a generated windows batch script in 0.8.0. The line:
if "%MAINCLASS%"=="" ( echo 'This "start" script requires a main class name as the first argument, because a mainClass was not specified in SBT and not autodetected by SBT (usually means you have zero, or more than one, main classes). You could specify in your SBT build: mainClass in Compile := Some("Whatever")' && EXIT 1)
gives the error:
. was unexpected at this time.
If the single quotes are replaced by double quotes it works ok. I dont think using single quotes will treat special characters such as parenthesis as part of a character sequence, e.g.
C:>IF "a"=="a" (echo 'blah ("blah") blah' && echo blah)
blah' was unexpected at this time.
C:>IF "a"=="a" (echo "blah ("blah") blah" && echo blah)
'blah "blah" blah'
blah
The text was updated successfully, but these errors were encountered: