Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support timeout for jobs and steps #98

Merged
merged 2 commits into from
Mar 14, 2023
Merged

Support timeout for jobs and steps #98

merged 2 commits into from
Mar 14, 2023

Conversation

povder
Copy link
Contributor

@povder povder commented Dec 9, 2021

Support timeout-minutes for jobs and steps.

@mdedetrich
Copy link
Contributor

@povder Thanks for the PR. I am not seeing any inherit problems with this feature. The only current problem is that due to the PR being so old there are a lot of merge conflicts but I think there is merit in resolving this and getting it over the edge.

If you have time to resolve the conflicts then let me know and I can then review the PR, otherwise I will just do the necessary changes ontop of the branch.

Copy link
Contributor

@mdedetrich mdedetrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have just merged main into this PR as well as resolving conflicts and tests are passing.

lgtm, thanks for the work.

@mdedetrich mdedetrich merged commit ba5bcc8 into sbt:main Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants