Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GitHub actions to use Node.js 16. #133

Merged
merged 1 commit into from
Jan 10, 2023
Merged

Conversation

jovilius
Copy link
Contributor

@jovilius jovilius commented Jan 9, 2023

@jovilius
Copy link
Contributor Author

jovilius commented Jan 9, 2023

What do you think about this @mdedetrich ?

@mdedetrich
Copy link
Contributor

Triggering CI, if it passes will approve

@mdedetrich
Copy link
Contributor

@jovilius The test is failing, you need to run sbt githubWorkflowGenerate and then commit the files in the .github folder.

@jovilius
Copy link
Contributor Author

jovilius commented Jan 9, 2023

@mdedetrich, I've updated both main and test code, generated and committed ci.yml in the .github folder. All tests passed locally.

@mdedetrich
Copy link
Contributor

@jovilius So the scripted tests are still failing (you can try locally by doing sbt scripted), as an example look at https://github.com/sbt/sbt-github-actions/actions/runs/3878106743/jobs/6613924426

For example one scripted test is failing because there are still references to actions/checkout@v2, i.e. https://github.com/sbt/sbt-github-actions/blob/main/src/sbt-test/sbtghactions/no-clean/.github/workflows/ci.yml#L30

@jovilius
Copy link
Contributor Author

jovilius commented Jan 9, 2023

Updated, please have a look @mdedetrich

@mdedetrich
Copy link
Contributor

@jovilius Thanks looking good. Due to having problems with the windows-latest ci (which we had to disable) I will run the tests locally on my Windows desktop tomorrow and if all looks good I will merge it.

Will also add @armanbilge as a reviewer but this looks fairly safe to me

@mdedetrich mdedetrich requested a review from armanbilge January 9, 2023 22:41
Copy link
Contributor

@armanbilge armanbilge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't look too carefully but sbt-typelevel rolled out a similar update already.

@jovilius
Copy link
Contributor Author

jovilius commented Jan 9, 2023

Great!

@mdedetrich mdedetrich merged commit caad082 into sbt:main Jan 10, 2023
@jovilius jovilius deleted the node16 branch January 10, 2023 12:44
This was referenced Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants