Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BuildInfoKey.of doesn't work with BuildInfoKey.map #117

Closed
dwijnand opened this issue Feb 23, 2018 · 0 comments
Closed

BuildInfoKey.of doesn't work with BuildInfoKey.map #117

dwijnand opened this issue Feb 23, 2018 · 0 comments
Assignees
@dwijnand

Comments

@dwijnand
Copy link
Member

The new API BuildInfoKey.of (introduced in v0.8.0 / #114) doesn't work with BuildInfoKey.map because it returns BuildInfoKey, aka BuildInfoKey.Entry[_] which means you can only map Any.
dwijnand added a commit to dwijnand/sbt-buildinfo that referenced this issue Feb 23, 2018
@dwijnand
Implicit convert TaskKey with the macro!
7d17af4 
When discussing the design of new in task graph execution, in sbt#114, we
completely didn't think of backing the existing TaskKey[A] to
BuildInfoKey.Entry[A] implicit conversion with the macro!

Fixes sbt#117
@dwijnand dwijnand mentioned this issue Feb 23, 2018
Merged
@dwijnand dwijnand self-assigned this Feb 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dwijnand dwijnand

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dwijnand