Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URLHandlerRegistry conflict with fm-sbt-s3-resolver plugin in SBT 1.0 #175

Closed
tpunder opened this issue Oct 20, 2017 · 11 comments
Closed

URLHandlerRegistry conflict with fm-sbt-s3-resolver plugin in SBT 1.0 #175

tpunder opened this issue Oct 20, 2017 · 11 comments

Comments

@tpunder
Copy link
Contributor

tpunder commented Oct 20, 2017

I'm trying to track down why fm-sbt-s3-resolver publishing is broken in SBT 1.0: tpunder/fm-sbt-s3-resolver#38

It seems that my URLHandlerRegistry.setDefault call:

https://github.com/frugalmechanic/fm-sbt-s3-resolver/blob/ab0188fd3439ee0346c173efae8b4ca462cbea2e/src/main/scala/fm/sbt/S3ResolverPlugin.scala#L98-L113

might be getting wiped out by a URLHandlerRegistry.setDefault call here:

if (configuration.updateOptions.gigahorse) URLHandlerRegistry.setDefault(gigahorseUrlHandler)
else URLHandlerRegistry.setDefault(basicUrlHandler)

Does this seem plausible? I've verified this is the problem.

@joan38
Copy link

joan38 commented Oct 31, 2017

Any news on this issue?

@Voltir
Copy link

Voltir commented Nov 6, 2017

+1 on this issue - rolling back to 0.13.16 fixed the problem for me

@jameskoch2
Copy link

I'd love to see a better hook for customizing the URLHandlerRegistry. I'd love to be able to use this to inject kerberos support, but at the moment I can't be confident a custom URLHandler won't get hosed and so am creating a full custom resolver to improve isolation.

@joan38
Copy link

joan38 commented Nov 7, 2017

This is regretion in SBT 1.0 as we see in tpunder/fm-sbt-s3-resolver#38

@edrevo
Copy link

edrevo commented Nov 16, 2017

Any update on this? This issue has a lot of thumbs up 😞

@joan38
Copy link

joan38 commented Nov 22, 2017

Still no news on this? This is invalidating the project https://github.com/frugalmechanic/fm-sbt-s3-resolver ...
I'm also happy to help if needed.

@dwijnand
Copy link
Member

Hey. I've created sbt/sbt#3758 to help track this issue. I've added it to the 1.0.5 milestone, and I hope it can be fixed by then.

If you, @joan38, or anyone wants to help by investigating what the underlying issue is, what possible solutions there might be, and/or submitting a fixing PR that would be great.

Unfortunately I don't have any real information regarding this issue in particular to give at this time.

@joan38
Copy link

joan38 commented Nov 22, 2017

Thanks @dwijnand for the update and info!

@tpunder
Copy link
Contributor Author

tpunder commented Nov 22, 2017

Here is what I'm playing with for fixing this: #183

@tpunder tpunder changed the title Possible URLHandlerRegistry conflict with fm-sbt-s3-resolver plugin in SBT 1.0 URLHandlerRegistry conflict with fm-sbt-s3-resolver plugin in SBT 1.0 Nov 22, 2017
@tpunder
Copy link
Contributor Author

tpunder commented Nov 22, 2017

#183 fixes the problem for me.

@tpunder
Copy link
Contributor Author

tpunder commented Nov 29, 2017

This is resolved with SBT 1.0.4! Thanks!

@tpunder tpunder closed this as completed Nov 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants