Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request]: Enhanced white-balance control #248

Open
FabianMPunkt opened this issue Nov 25, 2024 · 2 comments
Open

[Feature request]: Enhanced white-balance control #248

FabianMPunkt opened this issue Nov 25, 2024 · 2 comments
Assignees

Comments

@FabianMPunkt
Copy link

Is your feature request related to a problem? Please describe

The color-correction measures of Luciferin are absolutely amazing, but IMO the white-balance adjustments could be better.
My cheap WS2812B LEDs have an awful green/blue tint to them whithout any color correction. Luciferin lets me adjust the color-temperature, but not the hue (green/magenta). In my case this results in an awful green tint. I know my LEDs are cheap shit, but i still think that some basic hue correction would be a welcome addition.

These are my current color correction settings:
image

Here's a photo of my setup: in the picture the LEDs have a purple tint, but to the eye it's huge green tint for some reason. (camera white balance set to the white part of the screen)
20241125_152326

Describe the solution you'd like

In comparison. Prismatiks color correction works like this:
image
I think what Luciferin needs (at least in my case), is a simple magenta/green slider below the color temperature slider. The Cyan/Red & Yellow/Blue would be unnecessary considering the rest of Luciferins color correction tools are totally amazing.

Describe alternatives you've considered

Some nice RGBW LEDs would probably be the way to go xD

@sblantipodi
Copy link
Owner

Hi @FabianMPunkt really sorry for the late reply.
Can you tell me how a "new slider" may fix the problem?

Isn't there a green slider in the calibration section of the software already?
Why add another one?

Software can't fix bad hardware unfortunantly... Am I missing something?

@FabianMPunkt
Copy link
Author

Hey, sorry for my late response aswell 😅
I managed to make my green-tint a bit better by further adjusting the saturation and gamma.

My issue from the beginning still exists nonetheless.. Here's what i mean with a "new slider":
I am not able to set my LED's white to the same white my screen displays just by using the "color temperature" slider. The HSL sliders do a great deal of correcting individual colors, but they don't have any effect when the screen is almost pure white. (like most websites for example)
So what i need to correct the white-balance is some kind of overall hue control operating at the same level as the current color-temperature setting. I hope that makes sense to you :D

Additionally, I have some suggestions for the calibrations screen:
image

  • The gamma dropdown should be here aswell, so it is all on one screen. (kind of like in my highly professional drawing :P)
  • The temperature slider should have more granular control like the hue sliders.
  • Whenever i click on the color temperature, my lights turn off completely.
    https://github.com/user-attachments/assets/cb237a21-c318-4abb-90ee-4fee54a06637
    It looks like Luciferin switches to solid light mode whenever i try to change the color temperature. sometimes it goes right back to normal and applies the set temperature, other times it stays off until i restart Luciferin, other times Luciferin crashes completely.

My Setup:
ESP32-C3 Supermini connected via WiFi
126x WS2812B RGB LEDs at 100FPS
Windows 11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants