Fix/sheet alert crash on ipad #307
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Test modal window opened in fullscreen to avoid detection conflicts * Added accessibilityIdentifier for SDCAlertController and embedded alert view * Aligned test 11 with actual implementation
sberrevoets
reviewed
Jun 13, 2020
| @@ -324,6 +325,9 @@ public final class AlertController: UIViewController { | |||
| } | |||
|
|
|||
| self.alert.layoutIfNeeded() | |||
|
|
|||
| self.view.accessibilityIdentifier = type(of: self).description() | |||
| self.alert.accessibilityIdentifier = type(of: self.alert).description() | |||
There was a problem hiding this comment.
These changes seem irrelevant. If they represent some other type of bug, can you please open a separate ticket/PR?
sberrevoets
approved these changes
Jun 13, 2020
|
Closing this for inactivity, feel free to reopen! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #306