Decoded logging #88
Closed
Decoded logging #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hey chris, thanks for your work. unfortunately i can't merge your pull request, because the issue is already fixed in the current dev branch (http://github.com/rubiii/savon/tree/dev). the implementation now is quite different, so i hope this is going to work for you! cheers |
|
this should be fixed in the current dev branch. there's still some refactoring let to do, but i hope to get this released asap. |
|
please try savon 0.8.0.beta.1 |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #85. The simplest way to get this working was to have Savon::Request return the initialized Savon::Response so that Savon::Request who does the logging has access to the unencoded response body.
This should work for my use cases but looking for feedback.