An inconditional rescue may shadow XML parsing problems

[tokland]

I was working with a faulty SOAP server (it used wrong namespaces) and I was pretty confused because I got an empty hash but no error at all (but there was XML response there!). The problem, in lib/savon/soap/xml.rb:

  # Converts a given SOAP response +xml+ to a Hash.
  def self.parse(xml)
    Crack::XML.parse(xml) rescue {}
  end

I think it's better to remove the rescue and just let the parsing blow so the programmer is aware of the problem and deals with it as he/she sees fit.

[rubiii]

you're right about raising these exceptions and it's the default behavior of v0.9.0. please read the changelog and update if you can.

[tokland]

Thanks for the quick response. I can't update the gem for this project but I am happy to know it will be there in the future :-)