Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set both :host, and :hostname options on excon connection to avoid warning. #204

Merged
merged 1 commit into from
Jul 7, 2020

Conversation

pweldon
Copy link

@pweldon pweldon commented May 1, 2019

[excon][WARNING] hostname is missing! For IPv6 support, provide both host and hostname: Excon::Connection#new(:host => uri.host, :hostname => uri.hostname, ...).

…rning.

```
[excon][WARNING] hostname is missing! For IPv6 support, provide both host and hostname: Excon::Connection#new(:host => uri.host, :hostname => uri.hostname, ...).
```
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.09%) to 96.97% when pulling 84ae769 on pweldon:excon_set_request_hostname into 2fbd6b1 on savonrb:master.

@rogerleite rogerleite merged commit 9a73b7f into savonrb:master Jul 7, 2020
@pweldon pweldon deleted the excon_set_request_hostname branch July 8, 2020 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants