workaround for cURL related crashes on some systems

[chetan]

This is a workaround for the issue described here typhoeus/typhoeus#260.

Not sure if this is the best way to fix this, since there's no current way to pass options directly to the adapter. I think it should be safe enough to set this flag all the time, but not 100% sure.

Some more details on that particular flag: http://curl.haxx.se/libcurl/c/CURLOPT_NOSIGNAL.html

[tjarratt]

Hey @chetan, thanks for providing some context for this, as well as some details on the particular flag you're setting. I'm sorry, but I'm still a little confused about this. The issue on typhoeus doesn't seem to mention httpi or curb so I'm a little lost at what setting this flag in the curb adapter solves.

Does this fix a bug that you encountered with httpi and the curb adapter?

[chetan]

@tjarratt it's an issue with the behavior of libcurl which is the underlying library used by curb. I ran into this exact issue in production while using httpi+curb (and not typhoeus), hence the patch.

[rogerleite]

Hi @chetan thanks for warning us!
For now, if you need to set directly on adapter you can use something like this:

HTTPI.get request do |curb_client|
  curb_client.set(:NOSIGNAL, true)
end

It should works, i didn't test.
@tjarratt i think we can merge.

[chetan]

@rogerleite ah, ok. I didn't realize we had access to the underlying client there. That works too.

[rogerleite]

@chetan it's a "secret" feature! 😎

[tjarratt]

Cool, thanks for enlightening me with the discussion :)