Fixes #67 - Follow HTTP redirects. #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Fix deprecation warnings (be_true and be_false).
|
Thanks for fixing the deprecation warnings. I hadn't seen those, so it's nice that you fixed those up. This looks eminently reasonable. The only change I'd like to make is to log the redirect URL, but I'm cool adding that later. |
tjarratt
added a commit
that referenced
this pull request
Jun 26, 2014
…irects Fixes #67 - Follow HTTP redirects.
| adapter_class.request(method) | ||
| response = adapter_class.request(method) | ||
|
|
||
| if response and response.code == 302 and request.follow_redirect? |
There was a problem hiding this comment.
Here we should check for [301, 302, 303, 307, 308]. https://en.wikipedia.org/wiki/List_of_HTTP_status_codes#3xx_Redirection
Agree @tjarratt and @mikeantonelli?
|
@tjarratt @rogerleite I opened #121 to add the full range of redirect response codes and log the redirect location. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow HTTP redirects.
Add tests.
Fix deprecation warnings (be_true and be_false).