Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Order canceled #11

Open
stefanogriggio opened this issue Feb 20, 2024 · 3 comments · May be fixed by #12
Open

Order canceled #11

stefanogriggio opened this issue Feb 20, 2024 · 3 comments · May be fixed by #12

Comments

@stefanogriggio
Copy link

Hi.
I've upgraded from v 1.5 to v 2.4.1 on Prestashop 1.7.1.
I notice that if a customer closes the first Satispay modal once redirected to online.satispay.com,
a canceled order is created and the order_conf email is sent (and the cart emptied).

Is there a way to avoid this behaviour?

Could be an issue with our Prestashop version?

Thanks
Stefano

@keeara
Copy link
Contributor

keeara commented Mar 21, 2024

Hello,

The behavior you mentioned is the correct one, because when a user quits the payment view (tab where Satispay shows the QR), the payment would stay in 'PENDING' status and so we decide to close it and the order as well.

Regarding the email, we're aware of it and we're working to restructure the entire flow, and remove the mail send.
There should be a workaround to avoid sending email while the order is on 'Satispay' status [AWAITING_FOR_SATISPAY_PAYMENT].

@stefanogriggio
Copy link
Author

Hi Francesco.
Thanks for answering.

I agree, I can avoid sending order_conf email easily.

I don't agree on the behaviour.
A payment module shouldn't create an order and consequently empty a cart if a customer hasn't paid.
This works as a deterrent for a purchase and creates useless orders in the Prestashop backend.
I don't remember if the module fires the "order confirmation" page. If so, this can create "false" statistics.

But I'm not here to change your mind.

If I'll choose to use Satispay again, I'll be able to modify the module once the new flow is stable.

Have a nice one
Stefano

@keeara
Copy link
Contributor

keeara commented Mar 21, 2024

Ciao Stefano,

We know, I understand your point and I'm not saying that our flow is the best / works as it should.
Unfortunately our product is pretty outdated, and we're now working on a big code-review not only for Prestashop but basically every plugin owned by us.

Just to explain why the order is created, we use to do so because before being able to Pay with Satispay, we need to open the payment-session, and this is converted into an empty-order creation, that can go on, or just be cancelled in base of the payment callback.

As stated before, your point is correct and we're working to change this situation, it will take probably months but it's a needed change if we want to improve our product.

Many thanks for you feedback, we're open to any other suggestion! And if you need any other support, do not hesitate to reach us out Stefano.

Have a nice day

@EmanueleCoppola EmanueleCoppola linked a pull request Oct 17, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants