Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release broken on 0.12 without major version bump #946

Closed
huerlisi opened this issue Nov 9, 2016 · 5 comments
Closed

release broken on 0.12 without major version bump #946

huerlisi opened this issue Nov 9, 2016 · 5 comments

Comments

@huerlisi
Copy link

huerlisi commented Nov 9, 2016

First off: thanks for this wonderful package, we're using it with great success!

We're still using Node version 0.12 in some environments. These projects are now failing due to incompatibility of newer eslint versions.

eslint properly bumped the package version in a major release when requiring a newer node version. sass-lint did bump the dependency on eslint in 31d26aa. This did change the dependency version from ^2.7.0 to ^3.9.1 and does therefore allow breaking changes in the eslint dependency.

As said, this dependency upgrade broke sass-lint on node 0.12. So it is a breaking change for sass-lint. Unfortunately this change was included in a patch release.

I understand that you made the decission to drop support for 0.10 and 0.12 in #896. But I think actually breaking this support is something that according to semver is a breaking change and therefore should be only done in a major release.

@DanPurdy
Copy link
Member

DanPurdy commented Nov 9, 2016

We did agonise over this decision, came to the conclusion that we're not breaking any dependencies on our package this way but obviously with our lack of testing on 0.10 and 0.12 which are essentially dead platforms now I think there will start to be broken functionality upstream. But we should pull the ESLint version back for now I think and discuss it further. I'll look to get a patch release out today.

@alfaproject
Copy link

eslint should be a dev dependency though, and this wouldn't have been an issue in the first place?

@DanPurdy
Copy link
Member

DanPurdy commented Nov 9, 2016

We depend on it for the formatters currently as we dont have our own. They've always been a bit of an afterthought. Which I think is why we decided to do this in the first place, forgetting the formatters.

@DanPurdy
Copy link
Member

DanPurdy commented Nov 9, 2016

Either way @huerlisi 1.10.2 is out now with Eslint pegged back. I'll release an update to all the tools too. In fact I'll leave it open to make sure it is fixed.

@DanPurdy DanPurdy closed this as completed Nov 9, 2016
@DanPurdy DanPurdy reopened this Nov 9, 2016
@huerlisi
Copy link
Author

huerlisi commented Nov 9, 2016

Wow, that's a great relieve for us! Marvelous work!

(and it gave us a much needed push to migrate away from those old platforms)

@DanPurdy DanPurdy closed this as completed Nov 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants