Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No HighContrast theme for the tables #448

Closed
Zhirong2022 opened this issue Aug 9, 2023 · 1 comment · Fixed by #512
Closed

No HighContrast theme for the tables #448

Zhirong2022 opened this issue Aug 9, 2023 · 1 comment · Fixed by #512
Assignees
Labels
bug Something isn't working

Comments

@Zhirong2022
Copy link
Collaborator

Describe the bug
Install the SAS extension base on the official release. Specify the color theme as 'SAS High Contrast', open a table at Library section. No HighContrast theme for the table.

Steps to reproduce
Steps to reproduce the behavior:

  1. Sign in with a valid profile
  2. Specify the color theme as 'SAS High Contrast' through Manage->Themes->Color Theme
  3. Open a table at Library section

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
image

Environment (please complete the following information):
Client OS: [e.g. Windows 11]
Extension version: [e.g. v1.1.0]

@Zhirong2022 Zhirong2022 added the bug Something isn't working label Aug 9, 2023
@clangsmith clangsmith assigned scottdover and unassigned clangsmith and 2TomLi Aug 25, 2023
@clangsmith
Copy link
Contributor

window.activeColorTheme.kind will return ColorThemeKind.Light, Dark, HighContrast, or HighContrastLight. Can see how we are using it in PR #473 to pick an ODS style that reasonably matches VS Code color theme.

@scottdover scottdover linked a pull request Sep 14, 2023 that will close this issue
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants