Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The F3 and F8 keyboard shortcuts (to Run and Run selected) are no longer working #230

Closed
clangsmith opened this issue Apr 13, 2023 · 1 comment · Fixed by #231
Closed
Assignees
Labels
bug Something isn't working resolved The issues is resolved.

Comments

@clangsmith
Copy link
Contributor

Describe the bug
F3 and F8 would previously "Run Selected or All Code" and "Run All Code", respectively. It looks like these were accidentally removed (in commit 799515b). We just need to put these keybindings back.

Steps to reproduce

  1. Open any SAS program or create a new one.
  2. Hover over the running man icon, so that the tooltip appears.
  3. Notice that it says, "Run Selected or All SAS Code" -- it no longer has the "F3" shortcut on the end, indicating that F3 is no longer a keyboard shortcut for that command.
  4. Similarly, right-click in the SAS program editor to bring up the context menu and notice that F3 and F8 are no longer displayed next to "Run Selected or All SAS Code" nor "Run All SAS Code", again, reflecting these keyboard shortcuts are gone.
  5. With focus in the SAS program editor, press F3 and then F8 to confirm neither Run the SAS code anymore. (F3 brings up the Find popup.)

Expected behavior
F3 should be associated with the "Run Selected or All SAS Code" command and F8 associated with the "Run All SAS Code" command again.

Again, it appears the keybindings were simply accidentally removed in commit 799515b and just need to be added back.

Screenshots
image

Environment (please complete the following information):
Client OS: Windows 10
Extension version: v0.1.3
SAS version: Viya 2023.04

Additional context
Add any other context about the problem here.

@clangsmith clangsmith added the bug Something isn't working label Apr 13, 2023
@clangsmith
Copy link
Contributor Author

I'll handle this one.

@clangsmith clangsmith linked a pull request Apr 13, 2023 that will close this issue
@clangsmith clangsmith added the resolved The issues is resolved. label Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working resolved The issues is resolved.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants