chore: (IAC-1196) Update path pattern to support additional branches #345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jarpat
approved these changes
Oct 31, 2023
thpang
requested changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Updated the path pattern to support additional branches. Also noticed the child modules were not getting scanned for TFLint so updated the path and running it recursively.
On running TFLint recursively encountered a few errors and warnings which were resolved in this PR. Listing the errors below, changes to resolve the errors were made as per the TFLint recommendations.
-Error: Invalid function argument- Invalid value for "path" parameter: no file exists at "/.ssh/id_rsa.pub". We do not distribute this file as part of configuration code so setting the default path value returns error. Change was made similar to what we have in GCP. the fileslocals.tf,variables.tfandCONFIG-VARS.mdwere updated to resolve this error.terraform_unused_declarationsaks_cluster_rg_id,create_netapp,vnet_name,private_dns_zone_idwere removed.terraform_deprecated_indexSee the last commit on this PR for the three checks running successfully.
Tests