This repository has been archived by the owner on Jul 24, 2024. It is now read-only.
Use true-case-path to fix re-entrancy issue on Windows #2149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please remove the |
|
|
|
Thanks! |
|
No problem. Is there a timeline for the next patch release? Currently this bug is blocking some development on my team. |
|
@MLoughry +1 for this annoying issue :) |
|
Best estimate is some time this week |
xzyfer
added a commit
that referenced
this pull request
Nov 17, 2017
This was added in #2149 but doesn't support Node < 4
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1895
When using node-sass through multiple entry points (as can happen when using webpack) on Windows, the casing of the drive letter in the path can be inconsistent. Since Node is case-sensitive to a fault, this results in Node attempting to create a second instance of the native binding, which results in a
Module did not self-registererror.The fix is to use
true-case-pathto normalize the binding path, to prevent unintended duplicate bindings from occurring.