This repository has been archived by the owner on Jul 24, 2024. It is now read-only.
Fix proxy config for binary download #1789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xzyfer
force-pushed
the
fix/download-proxy-opts
branch
2 times, most recently
from
a7cb416
to
c34dbb4
Compare
In #1725 we started setting `proxy: ''` to defer proxy resolution logic to request. However `request` uses `hasOwnProperty` rather than falsey checks to determine if an option has been set. This caused `request` to believe were configuring a proxy so it didn't do it's own proxy resolution. Fixes #1785 Fixes #1787
xzyfer
force-pushed
the
fix/download-proxy-opts
branch
from
c34dbb4
to
3072444
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #1725 we started setting
proxy: ''to defer proxy resolutionlogic to request. However
requestuseshasOwnPropertyratherthan falsey checks to determine if an option has been set. This
caused
requestto believe were configuring a proxy so it didn'tdo it's own proxy resolution.
Fixes #1785
Fixes #1787