Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect definition for min() and max() #826

Closed
xzyfer opened this issue Jan 8, 2015 · 2 comments · Fixed by #832
Closed

Incorrect definition for min() and max() #826

xzyfer opened this issue Jan 8, 2015 · 2 comments · Fixed by #832
Assignees
@xzyfer
Labels
Bug - Confirmed Dev - Test Written
Milestone
3.2

Comments

@xzyfer
Copy link
Contributor

xzyfer commented Jan 8, 2015

Libsass currently defines function signatures of min() and max() as follows.

min($x1, $x2...)
max($x1, $x2...)

However Ruby sass defines them as follows

min($numbers...);
max($numbers...);

This is related to #813.
@xzyfer xzyfer mentioned this issue Jan 12, 2015
Merged
@xzyfer
Copy link
Contributor Author

xzyfer commented Jan 12, 2015

Spec added sass/sass-spec#238.

@xzyfer xzyfer added this to the 3.2 milestone Jan 12, 2015
@xzyfer
Copy link
Contributor Author

xzyfer commented Jan 12, 2015

This is fixed and will be 3.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xzyfer xzyfer

Labels
Bug - Confirmed Dev - Test Written
Projects
None yet
Milestone
3.2
Development

Successfully merging a pull request may close this issue.

Update the native number function signatures to match Ruby sass 3.4.9 xzyfer/libsass
1 participant
@xzyfer