Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

beta.1 throws on /deep/ selector #154

Closed
daniel-v opened this issue Jun 8, 2017 · 5 comments
Closed

beta.1 throws on /deep/ selector #154

daniel-v opened this issue Jun 8, 2017 · 5 comments

Comments

@daniel-v
Copy link

daniel-v commented Jun 8, 2017

Angular 2 emulated view encapsulation gives special meaning to /deep/ selector. This is true for TS and Dart versions as well. https://webdev.dartlang.org/angular/guide/component-styles#!#special-selectors

Expressions such as:

:host /deep/ .expected-optional-class { }

is valid and is a recommended way to deal with certain use-cases. Would be nice if dart-sass supported it.

@nschonni
Copy link
Contributor

nschonni commented Jun 8, 2017

Related sass/sass#2136

@nex3
Copy link
Contributor

nex3 commented Jun 8, 2017

This is intentional. The /deep/ syntax is not in any current CSS spec, nor has it been for some time. Its replacement, >>>, is explicitly marked as "invalid when used in stylesheets". Chrome support for /deep/ in stylesheets "being deprecated".

@nex3 nex3 closed this as completed Jun 8, 2017
@zoechi
Copy link

zoechi commented Jun 9, 2017

This makes dart-sass unusable with Angular (Dart and TS)

@zoechi
Copy link

zoechi commented Jun 9, 2017

@matanlurey do you have any thoughts on this?

@matanlurey
Copy link
Contributor

@nex3 and I have settled on using ::ng-deep in AngularDart 4.x.

We can back-port and release 3.2.0 to make this available to AngularDart users sooner. Follow:

angulardart/angular#454

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants