Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node 4.1 support #12

Closed
alanhogan opened this issue Sep 22, 2015 · 6 comments
Closed

Node 4.1 support #12

alanhogan opened this issue Sep 22, 2015 · 6 comments

Comments

@alanhogan
Copy link
Contributor

It looks like this is incompatible with node 4.1.0 at this time.

This isn’t of concern to me at this time, but thought there should probably be an issue to discuss / track support.

@alanhogan
Copy link
Contributor Author

(Seems like a lot of folks are having node-gyp problems in node 4.1. My current approach is sitting tight on 0.12 for the time being. Gotta say, the current major version of node jumping from 0 to 4 nearly overnight has confused a lot of people around me)

@chriseppstein
Copy link
Contributor

I bumped into this recently :( will dig in for next release.

@eoneill
Copy link
Contributor

eoneill commented Jan 27, 2016

See nodejs/node#2798

Workaround is to use g++ >= 4.8

@eoneill eoneill closed this as completed Jan 27, 2016
@alanhogan
Copy link
Contributor Author

Super long discussion there! I see only passing reference to g++ in it. Is eyeglass-spriting confirmed to work in node 4.x and newer?

@eoneill
Copy link
Contributor

eoneill commented Jan 27, 2016

Yep, confirmed eyeglass-spriting works in node 4+. I'm using it locally with node 5 and all tests are passing in travis now in 4+.

This was the change needed to get it passing in travis: eoneill@f2fc3ad

@alanhogan
Copy link
Contributor Author

Ah, thanks. That will be helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants