Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail fast off #2179

Merged
merged 6 commits into from
Dec 5, 2024
Merged

Fail fast off #2179

merged 6 commits into from
Dec 5, 2024

Conversation

jasquat
Copy link
Contributor

@jasquat jasquat commented Dec 5, 2024

Update packages flagged by trivy in our docker images.

Summary by CodeRabbit

  • New Features

    • Enhanced Docker environment with the addition of libraries libkrb5support0, libexpat1, and libaom3 for improved functionality and compatibility.
    • New step added to verify the existence of Trivy vulnerability scan results before uploading.
  • Bug Fixes

    • Updated severity level for vulnerabilities to only include CRITICAL, improving focus on critical issues.
  • Documentation

    • Comments in the Dockerfile and GitHub Actions workflow have been reformatted for better clarity.

Copy link
Contributor

coderabbitai bot commented Dec 5, 2024

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

The pull request introduces modifications to Dockerfile configurations across multiple components and updates the GitHub Actions workflow for building Docker images. Key changes include the addition of libraries for enhanced functionality, updates to the vulnerability scanning process using Trivy, and adjustments to the workflow to allow jobs to continue running even if one fails. The changes aim to improve the handling of dependencies and the overall build process without altering any public entity declarations.

Changes

File Path Change Summary
.github/workflows/build_docker_images.yml - Added fail-fast-off branch to push event triggers.
- Set fail-fast: false in job strategy.
- Updated Run Trivy vulnerability scanner step with double quotes for parameters and modified severity level to CRITICAL only.
- Added Check if Trivy results exist step to verify results file and set an environment variable for conditional execution of uploads.
- Minor formatting adjustments in comments.
connector-proxy-demo/Dockerfile - Added libkrb5support0 and libexpat1 libraries in the deployment stage.
- No changes to setup stage.
spiffworkflow-backend/Dockerfile - Added libkrb5support0 and libexpat1 libraries in the deployment stage.
- Updated poetry version from 1.4 to 1.6.1.
- Created new user _gunicorn.
spiffworkflow-frontend/Dockerfile - Added libkrb5support0, libexpat1, and libaom3 libraries in the installation commands.
- Maintained original setup and deployment processes with minor adjustments.

Possibly related PRs


📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between a065266 and 6427966.

📒 Files selected for processing (4)
  • .github/workflows/build_docker_images.yml (2 hunks)
  • connector-proxy-demo/Dockerfile (1 hunks)
  • spiffworkflow-backend/Dockerfile (1 hunks)
  • spiffworkflow-frontend/Dockerfile (2 hunks)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@burnettk burnettk merged commit fc4dff6 into main Dec 5, 2024
21 of 24 checks passed
@burnettk burnettk deleted the fail-fast-off branch December 5, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants