Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add managed role mention prefix support #289

Merged
merged 3 commits into from
Sep 29, 2021

Conversation

favna
Copy link
Member

@favna favna commented Sep 28, 2021

After this PR it will also be possible to trigger commands by using @ManagedRole command. This is useful because Discord adds a Managed Role with the same name as the Client when adding a bot with permissions, and especially in smaller servers it can happen that you accidentally mention the role instead of the bot.

@favna favna requested review from vladfrangu and kyranet September 28, 2021 19:58
@favna favna self-assigned this Sep 28, 2021
@favna favna force-pushed the feat/add-mentionPrefix-for-managed-role branch from f56eddf to bfd3d34 Compare September 28, 2021 22:08
@favna favna force-pushed the feat/add-mentionPrefix-for-managed-role branch from e4bf350 to 4d9c9e6 Compare September 29, 2021 17:43
@favna
Copy link
Member Author

favna commented Sep 29, 2021

Tested and confirmed to be working

image

@favna favna marked this pull request as ready for review September 29, 2021 17:55
Copy link
Member

@kyranet kyranet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Negative lines, oh yeah!

@favna favna merged commit 7846d6c into main Sep 29, 2021
@favna favna deleted the feat/add-mentionPrefix-for-managed-role branch September 29, 2021 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants