Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(preconditions): fixed TextOnly and NewsOnly #222

Merged
merged 4 commits into from
Jul 8, 2021
Merged

fix(preconditions): fixed TextOnly and NewsOnly #222

merged 4 commits into from
Jul 8, 2021

Conversation

sawa-ko
Copy link
Contributor

@sawa-ko sawa-ko commented Jul 7, 2021 •
edited
Loading

The condition that a channel be a text channel and news channel was wrong.

@sawa-ko
Fix(TextOnly/Precondition): Typo
8a3548f 
The condition that a channel be a text channel was wrong.
@sawa-ko sawa-ko requested review from favna and kyranet as code owners July 7, 2021 22:57
@sawa-ko sawa-ko changed the title Fix(TextOnly/Precondition): Typo Fix(TextOnly-NewsOnly/Precondition): Typo Jul 7, 2021
@kyranet kyranet changed the title Fix(TextOnly-NewsOnly/Precondition): Typo fix(preconditions): fixed TextOnly and NewsOnly Jul 8, 2021
kyranet
kyranet requested changes Jul 8, 2021
View reviewed changes
Copy link
Member

@kyranet kyranet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check for syntax errors

sawa-ko
sawa-ko commented Jul 8, 2021
View reviewed changes
Copy link
Contributor Author

@sawa-ko sawa-ko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

favna
favna approved these changes Jul 8, 2021
View reviewed changes
Copy link
Member

@favna favna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LMFAO that's pretty awkward

@favna
Copy link
Member

favna commented Jul 8, 2021

@all-contributors please add @kaname-png for code and bug

@allcontributors allcontributors bot mentioned this pull request Jul 8, 2021
Merged
@allcontributors
Copy link
Contributor

@favna

I've put up a pull request to add @kaname-png! 🎉

@favna favna merged commit 8cf1c2b into sapphiredev:main Jul 8, 2021
@sawa-ko sawa-ko deleted the patch-1 branch July 8, 2021 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyranet kyranet kyranet approved these changes

@favna favna favna approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sawa-ko @favna @kyranet