Skip to content
This repository has been archived by the owner on Jul 14, 2023. It is now read-only.

feat: support SAP CP CF PG Hyperscaler Service #43

Merged
merged 5 commits into from
Nov 16, 2020

Conversation

gregorwolf
Copy link
Contributor

No description provided.

Copy link
Collaborator

@vobu vobu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so in the tests, you're treating the dockerized posgres as if it were a hyperscaler service?

@gregorwolf
Copy link
Contributor Author

Yes, as a placeholder for test against a real connection.

@vobu
Copy link
Collaborator

vobu commented Nov 15, 2020

👍
then i'd suggest to run the same suite of tests against the scp hyperscaler postgres as we do against the dockerized one.
i'll look into that test re-use tomorrow.

allow running the same test suite
w/ different data sets
so we can once run against local/dockerized pg
and against hyperscaler(s).
excerpt from verbose log output:
[local] OData to Postgres dialect
//...
[scp] OData to Postgres dialect
//...
Copy link
Contributor Author

@gregorwolf gregorwolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vobu vobu merged commit c0ba1dd into sapmentors:main Nov 16, 2020
@gregorwolf gregorwolf deleted the sap-cp-pg-hyperscaler branch November 24, 2020 21:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants