Skip to content
This repository has been archived by the owner on Jul 14, 2023. It is now read-only.

feat: support virtual fields (fixes #204) #211

Merged
merged 17 commits into from
Oct 19, 2021

Conversation

vobu
Copy link
Collaborator

@vobu vobu commented Sep 27, 2021

No description provided.

@vobu vobu marked this pull request as draft September 27, 2021 16:12
@vobu
Copy link
Collaborator Author

vobu commented Sep 27, 2021

converted to draft until cds^5.5 is available

Copy link

@David-Kunz David-Kunz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @vobu ,

You can implement virtual field handling by substituting them:

{ 
  SELECT: {
    ...,
    columns: [
      { ref: ['myVirtualField'] }
    ]
}

to

{ 
  SELECT: {
    ...,
    columns: [
      { val: null, as: ['myVirtualField'] }
    ]
}

Notes:

  • Virtual fields can also appear in structured elements or expands
  • If they have a default value, you can replace null with it

Best regards,
David

@vobu
Copy link
Collaborator Author

vobu commented Oct 19, 2021

You can implement virtual field handling by substituting them:

thx for the hint, we just plugged into the core logic and got this going :)

@vobu vobu marked this pull request as ready for review October 19, 2021 16:49
@vobu vobu changed the title feat: support virtual fields feat: support virtual fields (fixes #204) Oct 19, 2021
@vobu
Copy link
Collaborator Author

vobu commented Oct 19, 2021

@gregorwolf please re-review

@vobu vobu merged commit 9a60e57 into sapmentors:main Oct 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants