Add field to operator selector control element #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
February 27, 2017 17:12
…l behaviour depending on how many rules are currently set
Codecov Report
@@ Coverage Diff @@
## master #28 +/- ##
==========================================
+ Coverage 66.37% 70.86% +4.49%
==========================================
Files 6 6
Lines 113 127 +14
Branches 13 17 +4
==========================================
+ Hits 75 90 +15
Misses 34 34
+ Partials 4 3 -1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition to PR #27, also adding the 'field' param to the operatorSelector on the Rule.
When providing my own operatorSelector, I wanted access to the first field so I could perform an async filter of operators against an API.
I could not achieve this by providing the 'getOperators' function as it does not allow for asynchronously retrieving the list. Given that the 'field' param is passed into 'getOperators' anyway, it seems reasonable to pass it to the controlElement as well..