Added more context information to controlElements #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
February 27, 2017 17:12
…l behaviour depending on how many rules are currently set
SamLoy
commented
Mar 7, 2017
| @@ -436,8 +436,15 @@ module.exports = reactProdInvariant; | |||
| /***/ (function(module, exports, __webpack_require__) { | |||
|
|
|||
| "use strict"; | |||
| /* | |||
There was a problem hiding this comment.
You might want to rebuild these dist files yourself as i might be using a different version of webpack causing all these extra changes..
Codecov Report
@@ Coverage Diff @@
## master #27 +/- ##
==========================================
+ Coverage 66.37% 70.86% +4.49%
==========================================
Files 6 6
Lines 113 127 +14
Branches 13 17 +4
==========================================
+ Hits 75 90 +15
Misses 34 34
+ Partials 4 3 -1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per #26
Exposes the nesting level to all controlElements, and the current rules to the RuleGroup controlElements.
You might want to rebuild the dist yourself and push to this PR as i might be using a different version of webpack to you.