Accept more types of eslint presets #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
|
sapegin
requested changes
Oct 5, 2020
packages/mrm-task-eslint/index.js
Outdated
| const match = presetName.match(presetNameRegex); | ||
|
|
||
| if (!match) { | ||
| throw new Error('Invalid preset name'); |
There was a problem hiding this comment.
Let's make it more clear for the user:
Suggested change
| throw new Error('Invalid preset name'); | |
| throw new Error(`Invalid preset name is passed to the eslint task: ${presetName}`); |
packages/mrm-task-eslint/index.js
Outdated
Comment on lines
20
to
32
| const scope = match[1] || ''; | ||
| let configName = match[2]; | ||
|
|
||
| if (!scope && !configName.startsWith(prefix)) { | ||
| configName = `${prefix}-${configName}`; | ||
| } else if (scope && !configName) { | ||
| configName = prefix; | ||
| } | ||
|
|
||
| const packageName = `${scope ? `${scope}/` : ''}${configName}`; | ||
|
|
||
| return packageName; | ||
| }; |
There was a problem hiding this comment.
Let's extract this piece to a function to avoid reassignment:
const [, scope = '', configNameRaw] = match;
// ...
const getConfigName = (configName, scope, prefix) => {
if (!scope && !configName.startsWith(prefix)) {
return `${prefix}-${configName}`;
} else if (scope && !configName) {
return prefix;
} else {
return configName;
}
}
packages/mrm-task-eslint/index.js
Outdated
Comment on lines
51
to
52
| const presetPackage = normalizePresetPackageName(eslintPreset); | ||
| packages.push(presetPackage); |
There was a problem hiding this comment.
A variable doesn't improve readability here:
Suggested change
| const presetPackage = normalizePresetPackageName(eslintPreset); | |
| packages.push(presetPackage); | |
| packages.push(normalizePresetPackageName(eslintPreset)); |
Codecov Report
|
|
Thanks, merging! 🦄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change expands the set of eslint preset names accepted by the eslint task to be closer to what is accepted by eslint for the
extendsconfiguration option including scoped packages and intra-package configs (e.g.eslint-config-airbnb/whitespace). This change does not include support for presets specified by a file path.It's worth noting that the
@eslint/eslintrcpackage exports anormalizePackageNamefunction, but there are a couple issues with that: