update mrm-task-license — add new entry for author name #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
|
sapegin
requested changes
Sep 23, 2020
packages/mrm-task-license/index.js
Outdated
| const isAnonymouseLicense = name => ANONYMOUS_LICENSES.indexOf(name) > -1; | ||
| const isAnonymousLicense = name => ANONYMOUS_LICENSES.includes(name); | ||
|
|
||
| function getAuthorName() { |
There was a problem hiding this comment.
I think passing pkg or even pkg.get('author') instead of reading package.json again would make more sense here.
There was a problem hiding this comment.
Yeah, it makes sense. Thank you for review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
Base on npm documentation: https://docs.npmjs.com/files/package.json#people-fields-author-contributors, author field can be an object on an string. In this PR try to add this behavior to mrm task license