Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use print instead of input after starting server #149

Merged
merged 1 commit into from
Jan 11, 2022

Conversation

klaa97
Copy link
Contributor

@klaa97 klaa97 commented Jan 11, 2022

Description

This super short PR fixes the usage of input after starting the server and replaces it with print.

The main problem solved is the necessity of having a TTY attached in case we use input - for example, with the previous input, Docker was failing if running without interactive mode.

@netlify
Copy link

netlify bot commented Jan 11, 2022

✔️ Deploy Preview for robyn canceled.

🔨 Explore the source changes: 1c8f230

🔍 Inspect the deploy log: https://app.netlify.com/sites/robyn/deploys/61ddf2246c0cf300074fd060

Copy link
Member

@sansyrox sansyrox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

Great work! ✨

@sansyrox sansyrox merged commit 6eba365 into sparckles:main Jan 11, 2022
@sansyrox
Copy link
Member

@klaa97 , just created a new release of robyn for this. https://pypi.org/project/robyn/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants