Skip to content

Commit

Permalink
Let sync op failures use stacktrace viewer
Browse files Browse the repository at this point in the history
This lets sync ops use the stacktrace viewer, just like how async ops
currently do. Requires some changes to the CIDER-nREPL code as well
which were submitted as CIDER-nREPL PR 327
clojure-emacs/cider-nrepl#327.
  • Loading branch information
sanjayl committed Mar 31, 2016
1 parent 1367053 commit b96e675
Showing 1 changed file with 1 addition and 5 deletions.
6 changes: 1 addition & 5 deletions nrepl-client.el
Original file line number Diff line number Diff line change
Expand Up @@ -968,11 +968,7 @@ sign of user input, so as not to hang the interface."
;; so we have to handle them differently until this is resolved
(if (member "eval-error" status)
(funcall nrepl-err-handler)
;; dump the stacktrace in the REPL
;; TODO: This has to be replaced with rendering of the
;; standard stacktrace buffer
(cider-repl-emit-interactive-stderr err)
(switch-to-buffer-other-window connection)))
(cider--render-stacktrace-causes (nrepl-dict-get response "pp-stacktrace"))))
(when-let ((id (nrepl-dict-get response "id")))
(with-current-buffer connection
(nrepl--mark-id-completed id)))
Expand Down

0 comments on commit b96e675

Please sign in to comment.