Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build time increased a lot #1569

Closed
yunstanford opened this issue May 10, 2019 · 3 comments · Fixed by #1581
Closed

build time increased a lot #1569

yunstanford opened this issue May 10, 2019 · 3 comments · Fixed by #1581
Assignees

Comments

@yunstanford
Copy link
Member

https://travis-ci.org/huge-success/sanic/builds
looks like build time increased a lot, after merging #1562

cc: @huge-success/sanic-core-devs @ahopkins

@ketan86
Copy link

ketan86 commented May 10, 2019

@yunstanford Agree, almost three times the previous build of #1562. This needs some investigation if build time increase like this is not expected.

@ahopkins
Copy link
Member

ahopkins commented May 13, 2019

This is indeed bizarre. The difference in the build is that we are replacing aiohttp for requests_async. The only other change that impacted the build was renaming pyproject.toml since we are only using it for building black right now and not as in relation to PEP 518.

The reason I did that was because the builds started conflicting with the toml file:

ERROR: Error installing 'file:///home/travis/build/huge-success/sanic': editable mode is not supported for pyproject.toml-style projects. pip is processing this project as pyproject.toml-style because it has a pyproject.toml file. Since the project has a setup.py and the pyproject.toml has no "build-backend" key for the "build_system" value, you may pass --no-use-pep517 to opt out of pyproject.toml-style processing. See PEP 517 for details on pyproject.toml-style projects.

@ahopkins
Copy link
Member

Just read @yunstanford PR linked above to httpcore (a dependency of requests-async, and potentially a new dependency of requests as well)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants