Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix auto_reloader in less naive way #1504

Closed
sjsadowski opened this issue Mar 3, 2019 · 8 comments
Closed

Fix auto_reloader in less naive way #1504

sjsadowski opened this issue Mar 3, 2019 · 8 comments

Comments

@sjsadowski
Copy link
Contributor

This is a placeholder for overhauling auto_reload again after the patch to fix it for 19.3

@chenjr0719
Copy link
Member

Actually, there is a tool named sanic-admin(check here) can do exactly what auto_reloader wants to do. I have been using it for a long time and it works pretty well. Maybe consider to leveraging(or integrate) sanic-admin to fix the problems of auto_reloader?

@sjsadowski
Copy link
Contributor Author

@chenjr0719 thanks for the tip!

@seemethere
Copy link
Member

Can we link the original patch to 19.3 so that we have some context into what was actually done?

@ahopkins
Copy link
Member

@seemethere, I believe this: 4260528

@ahopkins
Copy link
Member

Is this still relevant? What is wrong with auto_reload?

@ChihweiLHBird
Copy link
Member

@sjsadowski @chenjr0719 Are we still having any issue with auto_reload?

@ahopkins
Copy link
Member

Hmm... Not that I am aware of 🤔

I did some work on it with #2167 which will be released soon to allow listening on specific directories (helpful for static file changes, etc). I think this is probably stale. Removing necessary label so it can die off in time unless someone sees a better reason to keep it open.

@stale
Copy link

stale bot commented Jan 8, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If this is incorrect, please respond with an update. Thank you for your contributions.

@stale stale bot added the stale label Jan 8, 2022
@stale stale bot closed this as completed Mar 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants