Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the Section types work with the coordinates of the arrays from xarray #34

Closed
amoodie opened this issue Oct 20, 2020 · 0 comments · Fixed by #80
Closed

Make the Section types work with the coordinates of the arrays from xarray #34

amoodie opened this issue Oct 20, 2020 · 0 comments · Fixed by #80
Labels
Milestone

Comments

@amoodie
Copy link
Contributor

amoodie commented Oct 20, 2020

for example, when creating a StrikeSection, y=10 should be at the actual coordinate y==10, not the 10th cell in the y direction. This will be a breaking change, but I feel it is the correct way to handle this as input.

One option would be to implement another option y_cell=10 that is mutually exclusive with y=, and maintains the functionality of the current api.

@amoodie amoodie added this to the section api milestone Oct 20, 2020
@amoodie amoodie mentioned this issue Nov 11, 2021
5 tasks
@amoodie amoodie mentioned this issue Nov 23, 2021
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant