Planform implementation #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 29, 2021 10:55
…tyPlanform for base class for anythign other than the basic DataPlanform. Both subclass the Base Planform.
Codecov Report
@@ Coverage Diff @@
## develop #82 +/- ##
===========================================
+ Coverage 87.50% 88.10% +0.60%
===========================================
Files 9 9
Lines 2912 3027 +115
===========================================
+ Hits 2548 2667 +119
+ Misses 364 360 -4
Continue to review full report at Codecov.
|
added 8 commits
December 1, 2021 16:58
…be taken by idx in each of the three axes of the cube. Also implement some better visualization on with pyvista.
…s, change name of plan_set to planform_set:
added 3 commits
December 3, 2021 16:02
…or showing diff fields from specialty planform.
|
@elbeejay non breaking changes, implements the |
elbeejay
approved these changes
Dec 6, 2021
|
Cool, ya, I think so too. I guess we'll see how things work out and keep iterating, but that's okay 🤷 thanks for taking a look |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Development on an implementation for a
Planformapi consistent with theSectionapi.Planforminherits dimensions from the underlying data cube. The shoreline-related planforms now subclass from aSpecialtyPlanformwhich can be used for any planform data that is not just a slice of the cube.NOTE: this includes a non-breaking change for the
cube.show_planmethod. Code will still work, but should be updated to usequick_showorshow_planform, see below.Examples:
cube.show_planform()method now calls theshow()method of the Planform in question.cube.show_plan()method has been deprecated, and passes arguments along to the newcube.quick_show()method.cube.quick_show()method wrapsPlanformandSectionto easily show any straight-line slice from the underlying cube. e.g.,cube.quick_show('eta', idx=-1, axis=0)will show a planform from the last index.todo:
closes #12